neilcsmith-net commented on code in PR #6294:
URL: https://github.com/apache/netbeans/pull/6294#discussion_r1283455037
##########
platform/core.windows/src/org/netbeans/core/windows/services/NbPresenter.java:
##########
@@ -1599,7 +1584,10 @@ private Window findFocusedWindow() {
}
}
}
- while( null != w && !w.isShowing() ) {
+ while( null != w ) {
+ if ((w instanceof Frame || w instanceof Dialog) && w.isShowing()) {
+ break;
+ }
Review Comment:
Not sure it is. From the screenshot there, that is not triggered from a
popup window. I didn't look too much in depth at why the calculations are off
in that cases - maybe because it's a popup, or because it's smaller than the
dialog?? Anyway, using the same parenting logic to find the closest owning
frame or dialog to calculate the bounds makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
