errael commented on code in PR #6294:
URL: https://github.com/apache/netbeans/pull/6294#discussion_r1283474649
##########
platform/core.windows/src/org/netbeans/core/windows/services/DialogDisplayerImpl.java:
##########
@@ -227,9 +239,21 @@ public void showDialog () {
Window parent = noParent ? null : findDialogParent();
if (descriptor instanceof DialogDescriptor) {
- presenter = new NbDialog((DialogDescriptor) descriptor,
parent);
+ if (parent instanceof Dialog) {
+ presenter = new NbDialog((DialogDescriptor) descriptor,
(Dialog) parent);
+ } else if (parent instanceof Frame) {
+ presenter = new NbDialog((DialogDescriptor) descriptor,
(Frame) parent);
+ } else {
+ presenter = new NbDialog((DialogDescriptor) descriptor,
(Frame) null);
+ }
Review Comment:
Cool. That's the crux. I was wondering if there was a reason to prefer one
over the other. Guess not; just another corner case and as long as it doesn't
crash or lockup...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
