mbien commented on code in PR #6542:
URL: https://github.com/apache/netbeans/pull/6542#discussion_r1350233495
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java:
##########
@@ -480,6 +459,9 @@ public static int getVersionFromInstallDirectory(File
glassfishDir) {
case GF_7_0_4: return GLASSFISH_SERVER_7_0_4.getVersion();
case GF_7_0_5: return GLASSFISH_SERVER_7_0_5.getVersion();
case GF_7_0_6: return GLASSFISH_SERVER_7_0_6.getVersion();
+ case GF_7_0_7: return GLASSFISH_SERVER_7_0_7.getVersion();
+ case GF_7_0_8: return GLASSFISH_SERVER_7_0_8.getVersion();
+ case GF_7_0_9: return GLASSFISH_SERVER_7_0_9.getVersion();
Review Comment:
can this switch be eliminated by putting `GLASSFISH_SERVER_` enums into
`GF_` enums during construction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
