mbien commented on code in PR #6542:
URL: https://github.com/apache/netbeans/pull/6542#discussion_r1356042841
##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/ConfigBuilderProvider.java:
##########
@@ -193,16 +209,13 @@ public static ConfigBuilder getBuilder(final
GlassFishServer server) {
"GlassFish server entity shall not be null");
}
ConfigBuilder builder;
- synchronized (builders) {
- builder = builders.get(server);
- if (builder != null) {
- return builder;
- }
- String serverHome = server.getServerHome();
- builder = new ConfigBuilder(config, serverHome, serverHome,
serverHome);
- builders.put(server, builder);
+ builder = builders.computeIfPresent(server, (key, value) -> value);
+ if (builder != null) {
+ return builder;
}
- return builder;
+ String serverHome = server.getServerHome();
+ return builders.computeIfAbsent(server, key ->
+ new ConfigBuilder(config, serverHome, serverHome, serverHome));
Review Comment:
the the task of the method, which is to return the value of the map or
compute it if it isn't there yet, can be written with one operation on the map:
```java
public static ConfigBuilder getBuilder(final GlassFishServer server) {
if (server == null) {
throw new ServerConfigException(
"GlassFish server entity shall not be null");
}
String serverHome = server.getServerHome();
return builders.computeIfAbsent(server, key ->
new ConfigBuilder(config, serverHome, serverHome,
serverHome));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
