pepness commented on code in PR #6596:
URL: https://github.com/apache/netbeans/pull/6596#discussion_r1367799614
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/GlassfishInstanceProvider.java:
##########
@@ -71,17 +83,17 @@ public final class GlassfishInstanceProvider implements
ServerInstanceProvider,
public static final String JAKARTAEE10_DEPLOYER_FRAGMENT =
"deployer:gfv700ee10";
public static final String EE6WC_DEPLOYER_FRAGMENT = "deployer:gfv3ee6wc";
// NOI18N
public static final String PRELUDE_DEPLOYER_FRAGMENT = "deployer:gfv3"; //
NOI18N
- private static String EE6_INSTANCES_PATH = "/GlassFishEE6/Instances"; //
NOI18N
- private static String EE7_INSTANCES_PATH = "/GlassFishEE7/Instances"; //
NOI18N
- private static String EE8_INSTANCES_PATH = "/GlassFishEE8/Instances"; //
NOI18N
- private static String JAKARTAEE8_INSTANCES_PATH =
"/GlassFishJakartaEE8/Instances"; // NOI18N
- private static String JAKARTAEE9_INSTANCES_PATH =
"/GlassFishJakartaEE9/Instances"; // NOI18N
- private static String JAKARTAEE91_INSTANCES_PATH =
"/GlassFishJakartaEE91/Instances"; // NOI18N
- private static String JAKARTAEE10_INSTANCES_PATH =
"/GlassFishJakartaEE10/Instances"; // NOI18N
- private static String EE6WC_INSTANCES_PATH = "/GlassFishEE6WC/Instances";
// NOI18N
-
- public static String PRELUDE_DEFAULT_NAME = "GlassFish_v3_Prelude";
//NOI18N
- public static String EE6WC_DEFAULT_NAME = "GlassFish_Server_3.1"; // NOI18N
+ private static final String EE6_INSTANCES_PATH =
"/GlassFishEE6/Instances"; // NOI18N
+ private static final String EE7_INSTANCES_PATH =
"/GlassFishEE7/Instances"; // NOI18N
+ private static final String EE8_INSTANCES_PATH =
"/GlassFishEE8/Instances"; // NOI18N
+ private static final String JAKARTAEE8_INSTANCES_PATH =
"/GlassFishJakartaEE8/Instances"; // NOI18N
+ private static final String JAKARTAEE9_INSTANCES_PATH =
"/GlassFishJakartaEE9/Instances"; // NOI18N
+ private static final String JAKARTAEE91_INSTANCES_PATH =
"/GlassFishJakartaEE91/Instances"; // NOI18N
+ private static final String JAKARTAEE10_INSTANCES_PATH =
"/GlassFishJakartaEE10/Instances"; // NOI18N
+ private static final String EE6WC_INSTANCES_PATH =
"/GlassFishEE6WC/Instances"; // NOI18N
+
+ public static final String PRELUDE_DEFAULT_NAME = "GlassFish_v3_Prelude";
//NOI18N
+ public static final String EE6WC_DEFAULT_NAME = "GlassFish_Server_3.1"; //
NOI18N
Review Comment:
The fields are `public`, will this also require all modules to be rebuild?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists