pepness commented on code in PR #6596:
URL: https://github.com/apache/netbeans/pull/6596#discussion_r1367805761
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/GlassfishInstance.java:
##########
@@ -716,8 +711,8 @@ public static void writeInstanceToFile(
/** Configuration changes listener watching <code>domain.xml</code> file.
*/
private final transient DomainXMLChangeListener domainXMLListener;
- private transient InstanceContent ic;
- private transient Lookup localLookup;
+ private final transient InstanceContent ic;
+ private final transient Lookup localLookup;
Review Comment:
`transient` will prevent that these fields are written to a file (maybe a
glassfish config file?) or travel through the network (maybe when interacting
with a remote glassfish instance?).
Maybe that was a design choice since there are multiple `private transient`
fields (9). There are other `private final transient` fields, and this two
fields can also became `final`. That's why a change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
