matthiasblaesing commented on PR #6585: URL: https://github.com/apache/netbeans/pull/6585#issuecomment-1775760092
Sorry, this did not work. On github you can see that trivially on the "Commits" page, where after squashing a single commit with all changes should be present. I had a quick look at the current state of things and I see, that there are still unaddressed comments: - `ide/extbrowser/manifest.mf` is not modified, but lost its final newline - `ide/extbrowser/nbproject/project.properties` is essentially unmodified, but has changes line-endings - `ide/extbrowser/nbproject/project.xml` also looks as if new lines were changed - `ide/extbrowser/src/org/netbeans/modules/extbrowser/NbDdeBrowserImpl.java` null check for `cmd` is missing in line 277 My advice, after you are done, check the github view. github is not perfect, but it can help and if you see changes on github you did not intent, it is a sign, that the PR still needs work :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
