matthiasblaesing commented on PR #6585: URL: https://github.com/apache/netbeans/pull/6585#issuecomment-1779734372
@dragonsKnight5 I tried to do a rebase of this and aborted it as it failed multiple time and the commit count is very high. I think it would be best, if you create a new branch and replicate the changes there manually. While doing this: - ensure that your git client is configured not to mess with line endings (disable `core.autocrlf`), if in doubt line endings follow unix convention, `.bat` and `.cmd` are the exception (see `.gitattributes`) - ensure your author information is correct in the git client it should be "REALNAME <EMAIL>", this varies in your case. You can check it locally running `git log` in the project folder - before you commit run `git diff` if the whole file is reported as being changed, line endings were modified. Stop at that point, recheck you settings - before you open a PR, check the resulting commit git with git log to see if author information is correct - also check all comments, whether or not the remarks were addressed. For the `cmd.isEmpty() || cmd == null` check: This will still raise a `NullPointerException` if `cmd` is `null`. `||` and `&&` are evaluated from left to right, and thus first `isEmpty` is invoked and then the null check happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
