pepness commented on code in PR #6596:
URL: https://github.com/apache/netbeans/pull/6596#discussion_r1371973535
##########
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/GlassfishInstanceProvider.java:
##########
@@ -251,21 +260,21 @@ public GlassfishInstance getGlassfishInstance(String uri)
{
* @param si GlassFish server instance to be added.
*/
public void addServerInstance(GlassfishInstance si) {
- synchronized(instanceMap) {
- try {
- instanceMap.put(si.getDeployerUri(), si);
- activeDisplayNames.add(si.getDisplayName());
- if (instanceMap.size() == 1) { // only need to do if this
first of this type
- RegisteredDDCatalog catalog = getDDCatalog();
- if (null != catalog) {
- catalog.refreshRunTimeDDCatalog(this,
si.getGlassfishRoot());
- }
+ try {
Review Comment:
You are correct, it needs to be synchronized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
