mbien commented on code in PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#discussion_r1417815677
##########
ide/hudson.ui/src/org/netbeans/modules/hudson/ui/wizard/InstanceDialog.java:
##########
@@ -67,15 +67,15 @@ public void actionPerformed(ActionEvent e) {
public HudsonInstance show() {
dialog = DialogDisplayer.getDefault().createDialog(this);
dialog.setVisible(true);
- LOG.log(Level.FINE, "Added Hudson instance: {0}", created);
+ LOG.log(Level.FINE, "Added Jenkins instance: {0}", created);
return created;
}
@NbBundle.Messages({
"# UI logging of adding new server",
- "UI_HUDSON_SERVER_REGISTERED=Hudson server registered",
+ "UI_JENKINS_SERVER_REGISTERED=Jenkins server registered",
Review Comment:
we going to have to check if we should change the keys and the values, or
just the values
I think changing both should be fine, but lets see what others say.
##########
php/hudson.php/src/org/netbeans/modules/hudson/php/ui/options/HudsonOptionsPanelController.java:
##########
@@ -37,13 +37,13 @@
@OptionsPanelController.SubRegistration(
location=UiUtils.OPTIONS_PATH,
id=HudsonOptionsPanelController.OPTIONS_SUBPATH,
- displayName="#LBL_HudsonPHPOptionsName",
+ displayName="#LBL_JenkinsPHPOptionsName",
// toolTip="#LBL_OptionsTooltip"
position=160
)
public class HudsonOptionsPanelController extends OptionsPanelController
implements ChangeListener {
- public static final String OPTIONS_SUBPATH = "Hudson"; // NOI18N
+ public static final String OPTIONS_SUBPATH = "Jenkins"; // NOI18N
Review Comment:
same here
##########
php/hudson.php/src/org/netbeans/modules/hudson/php/options/HudsonOptions.java:
##########
@@ -36,7 +36,7 @@ public final class HudsonOptions {
// Do not change arbitrary - consult with layer's folder OptionsExport
// Path to Preferences node for storing these preferences
- private static final String PREFERENCES_PATH = "hudson"; // NOI18N
+ private static final String PREFERENCES_PATH = "jenkins"; // NOI18N
Review Comment:
this is something we will have to test.
config migration and config import/export should still work after this
change.
IMO: migration of hudson -> jenkins is probably not worth to implement, what
I mean by that is to check if the first-launch settings import from NB 21 to NB
22 still works if this path changes.
It might be better to not change this property and move that task for later
- I am not sure. (thats why I advocated to rename everything - since this does
make things easier)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
