mbien commented on PR #6797: URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1845905811
> I have pushed changes after making changes as told, was that the right thing to do? I am asking this as I am new to the community thats fine during review, but before merge it would be good if you would squash everything locally to one commit, make sure the commit message is how you like it and then force push into the PR. This PR would have to do that anyway, due to the commit author field, see https://github.com/apache/netbeans/pull/6797#pullrequestreview-1768358808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
