matthiasblaesing commented on PR #6797:
URL: https://github.com/apache/netbeans/pull/6797#issuecomment-1856404836
I already stated, that I think we should only follow the name change on the
surface. And it seems this PR is mostly in line with that. IMHO we gain little
renaming packages or other things. We risk though internal breakage as we have
sites that refer to modules, options, translations by name and these are hard
to catch.
Going through this PR @rothardo I notice:
- What is the license of the image `instance.png`? The old was part of the
donation from Oracle and thus relicensed to ALv2. A quick glance did not give
me info about the license situation around the logo, the press page from
Jenkins has a lot of yada-yada, but nothing substantial. I looked at the PNG
and SVG both don't seem to have licenses attached. At least in my home country
this makes the work non-redistributable.
- In most files only UI strings were changed. This is different in, were
also the keys are changed:
-
`ide/hudson.ui/src/org/netbeans/modules/hudson/ui/wizard/InstanceDialog.java`:
`UI_JENKINS_SERVER_REGISTERED` and `USG_JENKINS_SERVER_REGISTERED`
-
`php/hudson.php/src/org/netbeans/modules/hudson/php/resources/Bundle.properties`
(+ use-sites): `LBL_JenkinsExportName`
-
`php/hudson.php/src/org/netbeans/modules/hudson/php/ui/options/Bundle.properties`
(+ use-sites): `BL_JenkinsPHPOptionsName`
All in this looks sane to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
