tmysik commented on code in PR #6876:
URL: https://github.com/apache/netbeans/pull/6876#discussion_r1435680557
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointModel.java:
##########
@@ -110,8 +111,14 @@ public String getIconBase(Object node) throws
UnknownTypeException {
AbstractBreakpoint breakpoint = (AbstractBreakpoint) node;
if (!breakpoint.isEnabled()) {
return DISABLED_BREAKPOINT;
+ } else {
+ VALIDITY validity = breakpoint.getValidity();
+ if (validity.equals(VALIDITY.VALID) ||
validity.equals(VALIDITY.UNKNOWN)) {
Review Comment:
Cannot we improve this check? I mean, perhaps the Validity enum itself could
have isValid() method?
I am just thinking what will happen if we add a new Validity constant,
whether we will handle all the usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
