junichi11 commented on code in PR #6876:
URL: https://github.com/apache/netbeans/pull/6876#discussion_r1435726561
##########
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointModel.java:
##########
@@ -110,8 +111,14 @@ public String getIconBase(Object node) throws
UnknownTypeException {
AbstractBreakpoint breakpoint = (AbstractBreakpoint) node;
if (!breakpoint.isEnabled()) {
return DISABLED_BREAKPOINT;
+ } else {
+ VALIDITY validity = breakpoint.getValidity();
+ if (validity.equals(VALIDITY.VALID) ||
validity.equals(VALIDITY.UNKNOWN)) {
Review Comment:
`VALIDITY` is API.
https://github.com/apache/netbeans/blob/2141d37d045da9d247eb266d4c5f008255312128/ide/api.debugger/src/org/netbeans/api/debugger/Breakpoint.java#L53
Perhaps, we should have the `isValid()` method in the
[`Utils`](https://github.com/apache/netbeans/blob/master/php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/Utils.java)
class instead?
e.g.
```java
public static boolean isValid(Breakpoint breakpoint) {
VALIDITY validity = breakpoint.getValidity();
return validity == VALIDITY.VALID || validity == VALIDITY.UNKNOWN;
}
```
I found the 2 same conditions.
https://github.com/apache/netbeans/blob/2141d37d045da9d247eb266d4c5f008255312128/php/php.dbgp/src/org/netbeans/modules/php/dbgp/annotations/BrkpntAnnotation.java#L45
https://github.com/apache/netbeans/blob/2141d37d045da9d247eb266d4c5f008255312128/php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointModel.java#L103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
