lahodaj commented on code in PR #7034: URL: https://github.com/apache/netbeans/pull/7034#discussion_r1480267315
########## java/maven.embedder/external/apache-maven-3.9.6-httpclient-4.5.14-license.txt: ########## @@ -0,0 +1,565 @@ +Name: httpclient 4.5.14, as part of Maven distribution Review Comment: I am not sure I understand the complaint. This patch will not (to the best of my knowledge) make this part of the license for the source. It will make it part of the license for the binary. This is very similar to what we do e.g. here: https://github.com/apache/netbeans/blob/b5bf037d91bc3f0fa4a09518ba4fd6c105f965c4/java/maven.embedder/external/apache-maven-3.9.6-javax.annotation-api-license.txt (and for a somewhat similar license) I wonder if there's some specific concern around MPL (or including MPL) that would warrant investigating alternative options? (Note that even the official binary distributed by Apache Commons has Apache 2.0 + MPL 2.0, it is just the specific artifact that is missing MPL.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
