matthiasblaesing commented on code in PR #7034: URL: https://github.com/apache/netbeans/pull/7034#discussion_r1480324632
########## ide/swing.validation/external/simplevalidation-1.14.1-notice.txt: ########## @@ -0,0 +1,3 @@ +ValidationAPI version 1.14.1 Review Comment: I'm inclined not to honor broken licenses. The Apache license explicitly states, that the file you have to look for as a user is NOTICE. If it is not there, I would ignore it, the user obiously was not interested in it either. There is also no NOTICE in the binary jar, further strengthening the point. ########## ide/slf4j.api/external/slf4j-api-1.7.36-license.txt: ########## @@ -1,10 +1,10 @@ Name: SLF4J Version: 1.7.36 -License: MIT-slf4j +License: MIT-slf4j-22 Review Comment: The file `nbbuild/licenses/MIT-slf4j` could be removed. Not really a problem, but cleaning up now would IMHO make sense. ########## java/maven.embedder/external/apache-maven-3.9.6-httpclient-4.5.14-license.txt: ########## @@ -0,0 +1,565 @@ +Name: httpclient 4.5.14, as part of Maven distribution Review Comment: For httpclient (both httpclient and httpcore) the license in the package is pure ALv2.0. I would suggest to stick with the upstream license and not pretend to know better. Once httpclient gets updated, I see no problem to follow though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
