mbien commented on code in PR #7062:
URL: https://github.com/apache/netbeans/pull/7062#discussion_r1486989359
##########
platform/core.netigso/src/org/netbeans/core/netigso/Netigso.java:
##########
@@ -118,7 +118,7 @@ protected void prepare(Lookup lkp, Collection<? extends
Module> preregister) {
if (framework == null) {
readBundles();
- Map configMap = new HashMap();
+ Map configMap = new HashMap<>();
Review Comment:
lets take a look at the usages:
the map is passed to `frameworkFactory.newFramework` which expects
`Map<String, String>`, however one entry which is put into the map using the
`"netigso.archive" key` is not a String.
This indicates that this is either a bug or a hack.
https://github.com/search?q=repo%3Aapache%2Fnetbeans%20%22netigso.archive%22&type=code
search shows that the key is used and that the type is expected to be in fact
not a String.
There is likely no way to set a type to the map without making more changes
in other places, since the map is not used in a typesafe manner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
