mbien commented on code in PR #7062:
URL: https://github.com/apache/netbeans/pull/7062#discussion_r1506711534
##########
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/application/ApplicationProxy.java:
##########
Review Comment:
this one too
##########
platform/openide.filesystems/src/org/openide/filesystems/DefaultAttributes.java:
##########
@@ -935,8 +935,7 @@ private ElementHandler parseSecondLevel(final StringBuffer
fileName) {
private final String[] ELM_KEYS = { "FILEOBJECT" }; //
NOI18N
private final String[] MANDAT_ATTR_KEYS = { "NAME" }; //
NOI18N
- @Override
- public void internalStartElement(String elemName, HashMap
mapMandatory, HashMap mapAllowed)
+ public void internalStartElement(String elemName, Map
mapMandatory, Map mapAllowed)
Review Comment:
override needs to come back
##########
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/api/common/DescriptionInterface.java:
##########
Review Comment:
this interface is in public API I think.
##########
platform/openide.filesystems/src/org/openide/filesystems/DefaultAttributes.java:
##########
@@ -980,8 +979,7 @@ private ElementHandler parseThirdLevel(final StringBuffer
fileName) {
private final String[] ELM_KEYS = { "ATTR" }; // NOI18N
private final String[] MANDAT_ATTR_KEYS = { "NAME" }; //
NOI18N
- @Override
- public void internalStartElement(String elemName, HashMap
mapMandatory, HashMap mapAllowed)
+ public void internalStartElement(String elemName, Map
mapMandatory, Map mapAllowed)
Review Comment:
override removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
