neilcsmith-net commented on PR #51: URL: https://github.com/apache/netbeans-nbpackage/pull/51#issuecomment-1973512216
Any changes should be in both netbeans and netbeans-nbpackage repos. In fact, the main netbeans repo should really be the canonical location, and this should be kept in sync with it. That's what I meant by matching PR here in https://github.com/apache/netbeans/pull/3168#issuecomment-1966409553 The icon here is used for the app bundle and installer, but the icon is also referenced in the IDE launcher script. The icon looks good to me, but should go through review into the IDE repo before merging here. I'm not sure about @matthiasblaesing comments about use of `netbeans.icns` away from macOS. It could be we merge the svg icon from NBPackage into the IDE repo for that purpose instead?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
