mhalachev commented on PR #51: URL: https://github.com/apache/netbeans-nbpackage/pull/51#issuecomment-1974857999
Thank you for your feedback! > Just marking as request changes to ensure this doesn't get merged until this change is reflected in the main IDE repo. @neilcsmith-net I'll open a matching PR there. > Agree with this; the new icon is only needed/desirable for MacOS, where it needs to look good next to other icons in the same style. As @eirikbakke mentioned, this is indeed specific to macOS, the original icon is ok on other platforms as seen on the screenshots @mbien provided. > Do you have an svg version of the icns? @oyarzun No, the `.icns` was initially designed as a set of bitmaps in various resolutions. However, you can find the original icon as svg in this repo. > And maybe adding a PR that will update the frame icon for macOS when NetBeans is minimized ([apache/netbeans#3168 (comment)](https://github.com/apache/netbeans/pull/3168#issuecomment-1171699186)). It would be nice to address this as well. Can we go even further and find a way to provide a thumbnail for the minimised window, as currently minimising the application results in having two NetBeans icons in the Dock? <img width="226" alt="minimised" src="https://github.com/apache/netbeans-nbpackage/assets/2463597/090625bc-559f-487f-918a-7a3e0147fd76";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
