mhalachev commented on PR #7239:
URL: https://github.com/apache/netbeans/pull/7239#issuecomment-2045491454

   > hopefully this change fixes things. I can't remember why the extra pixel 
was there, but seems OK without now, and I guess was allowing a background 
colour to show through???
   
   @neilcsmith-net I can confirm that it now works as expected:
   
   <img width="262" alt="macos-theme" 
src="https://github.com/apache/netbeans/assets/2463597/0b09da2a-33b1-47d9-bba0-1fe050e5c77d";>
   
   Indeed, it was possibly either a background color popping in or an 
explicitly set border in the theme if the default is transparent...
   
   PS: Just noticed something... the shortcut color in 
https://github.com/apache/netbeans/pull/7171 also gets black with CDE/Motif and 
Mac OS X themes:
   <img width="356" alt="Motif" 
src="https://github.com/apache/netbeans/assets/2463597/cea6dfa5-52c0-45ac-90cd-fbee0bf42c8d";>
   
   Here is FlatLaf (blue):
   <img width="338" alt="FlatLaf" 
src="https://github.com/apache/netbeans/assets/2463597/c17b1263-4e1b-4940-b65e-917bc2fb5601";>
   
   Maybe it could be fixed similarly to links and buttons colours for the 
dashboard, but for the shortcut color in the editor background... 🤔 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to