lahodaj commented on code in PR #7268: URL: https://github.com/apache/netbeans/pull/7268#discussion_r1565739704
########## webcommon/libs.graaljs/external/icu4j-24.0.0-license.txt: ########## @@ -2,8 +2,8 @@ Name: icu4j Description: icu4j license License: MIT-icu4j-58 Origin: http://site.icu-project.org/ -Version: 67.1 -Files: icu4j-67.1.jar +Version: 24.0.0 +Files: icu4j-24.0.0.jar Review Comment: The license here does not match the license in the binary, in a significant way, I think. My suggestion here would be to use the text from here: https://raw.githubusercontent.com/unicode-org/icu/248b1c2a13fc7fc346e9e9419c4794df8a590ad9/LICENSE and remove everything related to ICU4C, i.e. everything from line `File: aclocal.m4 (only for ICU4C)`. That should mostly match the LICENSE, and hopefully match what we use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
