sdedic commented on code in PR #7268:
URL: https://github.com/apache/netbeans/pull/7268#discussion_r1566821345
##########
ide/libs.graalsdk.system/nbproject/project.xml:
##########
@@ -82,12 +82,36 @@
</test-dependencies>
<public-packages/>
<class-path-extension>
- <runtime-relative-path></runtime-relative-path>
- <binary-origin>external/graal-sdk-20.3.0.jar</binary-origin>
+
<runtime-relative-path>ext/launcher-common-24.0.0.jar</runtime-relative-path>
+
<binary-origin>external/launcher-common-24.0.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
- <runtime-relative-path></runtime-relative-path>
-
<binary-origin>external/launcher-common-20.3.0.jar</binary-origin>
+
<runtime-relative-path>ext/jline-24.0.0.jar</runtime-relative-path>
+ <binary-origin>external/jline-24.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/collections-24.0.0.jar</runtime-relative-path>
+ <binary-origin>external/collections-24.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/jniutils-24.0.0.jar</runtime-relative-path>
+ <binary-origin>external/jniutils-24.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/launcher-common-24.0.0.jar</runtime-relative-path>
+
<binary-origin>external/launcher-common-24.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/nativeimage-24.0.0.jar</runtime-relative-path>
+ <binary-origin>external/nativeimage-24.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/polyglot-24.0.0.jar</runtime-relative-path>
+ <binary-origin>external/polyglot-24.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/word-24.0.0.jar</runtime-relative-path>
+ <binary-origin>external/word-24.0.0.jar</binary-origin>
Review Comment:
>the references to the GraalVM implementations at runtime in
libs.graalsdk.system make no sense to me.
Thanks for noticing ! Seem I was copying from libs.graal to
libs.graal.system (for compilation purposes) and did not prune after.
Addressed in b43e68dbdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
