tmysik commented on code in PR #7387:
URL: https://github.com/apache/netbeans/pull/7387#discussion_r1608051235
##########
php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/Scalar.java:
##########
@@ -29,7 +29,7 @@ public class Scalar extends Expression {
public enum Type {
INT, // 'int'
- REAL, // 'real'
+ FLOAT, // 'float'
Review Comment:
Right, we cannot do this if it is an API/SPI. If you really want to do that,
the steps should be like:
- in release X
- deprecate the `REAL` type + document all the details (why deprecated
and when it will be removed)
- add new `FLOAT` type
- change the code under our control to start using the `FLOAT` type
- increase the minor API version of the module
- in release X + Y (Y is quite a big number, we cannot do it in the near
future, we need to give time to our API consumers - plugins - to change their
code):
- remove the `REAL` type
- increase the **major** API version of the module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
