junichi11 commented on code in PR #7387:
URL: https://github.com/apache/netbeans/pull/7387#discussion_r1662491703
##########
php/php.editor/src/org/netbeans/modules/php/editor/typinghooks/PhpCommentGenerator.java:
##########
@@ -541,7 +541,7 @@ public void scan(ASTNode node) {
case INT:
type =
Type.INTEGER;
break;
- case REAL:
Review Comment:
It should be OK (I assume all `REAL` types were replaced with `FLOAT` in the
parser).
But I would leave it, just in case.
##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP54UnhandledError.java:
##########
@@ -156,7 +156,7 @@ public void visit(Scalar node) {
if (CancelSupport.getDefault().isCancelled()) {
return;
}
- if (node.getScalarType().equals(Scalar.Type.REAL) &&
node.getStringValue().startsWith(BINARY_PREFIX)) {
+ if (node.getScalarType().equals(Scalar.Type.FLOAT) &&
node.getStringValue().startsWith(BINARY_PREFIX)) {
Review Comment:
It should be OK (I assume all `REAL` types were replaced with `FLOAT` in the
parser).
But I would keep both types, just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
