mbien commented on PR #7201: URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2130795567
Hi @lahodaj and reviewers, I tested this by rebasing this PR on latest master which contains the other `javac.release` changes (https://github.com/apache/netbeans/pull/7247), and then adding another commit which sets `javac.release` to all modules which set `OpenIDE-Module-Java-Dependencies` in their manifest. I did also open all involved modules with NB 22 and checked if the editor is picking everything up properly (verifies that https://github.com/apache/netbeans/pull/7188 is working). tests are currently running at https://github.com/mbien/netbeans/actions/runs/9233121350?pr=1 since my branch is already rebased and squashed, I could force push this into this PR if you want and we take another quick look and merge as two commits? https://github.com/mbien/netbeans/commits/java-modules-using-jdk9-plus/ - https://github.com/mbien/netbeans/commit/646f89dced05ac1a0214be118f81eb052b3cb6eb this PR, rebased and squashed - https://github.com/mbien/netbeans/commit/af7798df16a63f93e6a097e09c2c9dcce578523a additional commit which sets `javac.release` let me know what to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
