mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132219529
I have another change to offer. We could now remove the JDK manifest entries
entirely, since the build adds them by looking at the `javac.release` property
if they aren't there yet.
-
https://github.com/mbien/netbeans/commit/8db6aabca483f87ccafa1782bbe91a4d3c7671d2
This would simplify the module configuration to a single value in
`project.properties`.
to validate this I diffed the manifest dump of all jars before/after a
rebuild using this script:
```bash
find nbbuild/netbeans/ -type f -iname '*.jar' | sort | while read line || [[
-n $line ]];
do
echo "$line/META-INF/MANIFEST.MF"
unzip -p $line META-INF/MANIFEST.MF
done
```
checking all jars in `nbbuild/netbeans/` should be sufficient, right?
@matthiasblaesing
i could squash this into my other commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
