mbien commented on code in PR #7419: URL: https://github.com/apache/netbeans/pull/7419#discussion_r1619310448
########## platform/o.apache.commons.commons_io/nbproject/org-apache-commons-commons_io.sig: ########## Review Comment: so we wrap version 2.16.0 right now: https://github.com/apache/netbeans/blob/faa1f932458adfa8f9b628c15da2c6e6ebf16653/platform/o.apache.commons.commons_io/external/binaries-list#L17 lets look at the error: ``` Class org.apache.commons.io.build.AbstractOriginSupplier "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setWriter(java.io.Writer) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setURI(java.net.URI) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setReader(java.io.Reader) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setPath(java.lang.String) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setOutputStream(java.io.OutputStream) "E3.1 - Changing method signature and/or return type" : method protected {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setOrigin(org.apache.commons.io.build.AbstractOrigin) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setInputStream(java.io.InputStream) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setFile(java.io.File) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setCharSequence(java.lang.CharSequence) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractOriginSupplier.setByteArray(byte[]) Class org.apache.commons.io.build.AbstractStreamBuilder "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractStreamBuilder.setOpenOptions(java.nio.file.OpenOption[]) "E3.1 - Changing method signature and/or return type" : method protected {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractStreamBuilder.setCharsetDefault(java.nio.charset.Charset) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractStreamBuilder.setCharset(java.lang.String) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractStreamBuilder.setBufferSizeMax(int) "E3.1 - Changing method signature and/or return type" : method protected {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractStreamBuilder.setBufferSizeDefault(int) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractStreamBuilder.setBufferSizeChecker(java.util.function.IntUnaryOperator) "E3.1 - Changing method signature and/or return type" : method public {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractStreamBuilder.setBufferSize(int) Class org.apache.commons.io.build.AbstractSupplier "E3.1 - Changing method signature and/or return type" : method protected {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractSupplier.asThis() ``` in sig file: ``` CLSS public abstract org.apache.commons.io.build.AbstractOriginSupplier<%0 extends java.lang.Object, %1 extends org.apache.commons.io.build.AbstractOriginSupplier<{org.apache.commons.io.build.AbstractOriginSupplier%0},{org.apache.commons.io.build.AbstractOriginSupplier%1}>> cons public init() meth protected boolean hasOrigin() meth protected org.apache.commons.io.build.AbstractOrigin<?,?> checkOrigin() meth protected org.apache.commons.io.build.AbstractOrigin<?,?> getOrigin() meth protected static org.apache.commons.io.build.AbstractOrigin$ByteArrayOrigin newByteArrayOrigin(byte[]) meth protected static org.apache.commons.io.build.AbstractOrigin$CharSequenceOrigin newCharSequenceOrigin(java.lang.CharSequence) meth protected static org.apache.commons.io.build.AbstractOrigin$FileOrigin newFileOrigin(java.io.File) meth protected static org.apache.commons.io.build.AbstractOrigin$FileOrigin newFileOrigin(java.lang.String) meth protected static org.apache.commons.io.build.AbstractOrigin$InputStreamOrigin newInputStreamOrigin(java.io.InputStream) meth protected static org.apache.commons.io.build.AbstractOrigin$OutputStreamOrigin newOutputStreamOrigin(java.io.OutputStream) meth protected static org.apache.commons.io.build.AbstractOrigin$PathOrigin newPathOrigin(java.lang.String) meth protected static org.apache.commons.io.build.AbstractOrigin$PathOrigin newPathOrigin(java.nio.file.Path) meth protected static org.apache.commons.io.build.AbstractOrigin$ReaderOrigin newReaderOrigin(java.io.Reader) meth protected static org.apache.commons.io.build.AbstractOrigin$URIOrigin newURIOrigin(java.net.URI) meth protected static org.apache.commons.io.build.AbstractOrigin$WriterOrigin newWriterOrigin(java.io.Writer) meth protected {org.apache.commons.io.build.AbstractOriginSupplier%1} setOrigin(org.apache.commons.io.build.AbstractOrigin<?,?>) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setByteArray(byte[]) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setCharSequence(java.lang.CharSequence) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setFile(java.io.File) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setFile(java.lang.String) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setInputStream(java.io.InputStream) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setOutputStream(java.io.OutputStream) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setPath(java.lang.String) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setPath(java.nio.file.Path) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setReader(java.io.Reader) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setURI(java.net.URI) meth public {org.apache.commons.io.build.AbstractOriginSupplier%1} setWriter(java.io.Writer) supr org.apache.commons.io.build.AbstractSupplier<{org.apache.commons.io.build.AbstractOriginSupplier%0},{org.apache.commons.io.build.AbstractOriginSupplier%1}> hfds origin CLSS public abstract org.apache.commons.io.build.AbstractStreamBuilder<%0 extends java.lang.Object, %1 extends org.apache.commons.io.build.AbstractStreamBuilder<{org.apache.commons.io.build.AbstractStreamBuilder%0},{org.apache.commons.io.build.AbstractStreamBuilder%1}>> cons public init() meth protected int getBufferSize() meth protected int getBufferSizeDefault() meth protected java.io.InputStream getInputStream() throws java.io.IOException meth protected java.io.OutputStream getOutputStream() throws java.io.IOException meth protected java.io.Reader getReader() throws java.io.IOException meth protected java.io.Writer getWriter() throws java.io.IOException meth protected java.lang.CharSequence getCharSequence() throws java.io.IOException meth protected java.nio.charset.Charset getCharsetDefault() meth protected java.nio.file.OpenOption[] getOpenOptions() meth protected java.nio.file.Path getPath() meth protected {org.apache.commons.io.build.AbstractStreamBuilder%1} setBufferSizeDefault(int) meth protected {org.apache.commons.io.build.AbstractStreamBuilder%1} setCharsetDefault(java.nio.charset.Charset) meth public !varargs {org.apache.commons.io.build.AbstractStreamBuilder%1} setOpenOptions(java.nio.file.OpenOption[]) meth public java.nio.charset.Charset getCharset() meth public {org.apache.commons.io.build.AbstractStreamBuilder%1} setBufferSize(int) meth public {org.apache.commons.io.build.AbstractStreamBuilder%1} setBufferSize(java.lang.Integer) meth public {org.apache.commons.io.build.AbstractStreamBuilder%1} setBufferSizeChecker(java.util.function.IntUnaryOperator) meth public {org.apache.commons.io.build.AbstractStreamBuilder%1} setBufferSizeMax(int) meth public {org.apache.commons.io.build.AbstractStreamBuilder%1} setCharset(java.lang.String) meth public {org.apache.commons.io.build.AbstractStreamBuilder%1} setCharset(java.nio.charset.Charset) supr org.apache.commons.io.build.AbstractOriginSupplier<{org.apache.commons.io.build.AbstractStreamBuilder%0},{org.apache.commons.io.build.AbstractStreamBuilder%1}> hfds DEFAULT_MAX_VALUE,DEFAULT_OPEN_OPTIONS,bufferSize,bufferSizeChecker,bufferSizeDefault,bufferSizeMax,charset,charsetDefault,defaultSizeChecker,openOptions CLSS public abstract org.apache.commons.io.build.AbstractSupplier<%0 extends java.lang.Object, %1 extends org.apache.commons.io.build.AbstractSupplier<{org.apache.commons.io.build.AbstractSupplier%0},{org.apache.commons.io.build.AbstractSupplier%1}>> cons public init() intf org.apache.commons.io.function.IOSupplier<{org.apache.commons.io.build.AbstractSupplier%0}> meth protected {org.apache.commons.io.build.AbstractSupplier%1} asThis() supr java.lang.Object ``` code: https://github.com/apache/commons-io/blob/rel/commons-io-2.16.0/src/main/java/org/apache/commons/io/build/AbstractSupplier.java looks like the generics are indeed the issue: - the sig file looks correct to me since it matches the code - the error looks wrong? ``` Class org.apache.commons.io.build.AbstractSupplier "E3.1 - Changing method signature and/or return type" : method protected {org.apache.commons.io.build.AbstractStreamBuilder%1} org.apache.commons.io.build.AbstractSupplier.asThis() ``` it should be `{org.apache.commons.io.build.AbstractSupplier%1}` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
