ebarboni commented on PR #7419:
URL: https://github.com/apache/netbeans/pull/7419#issuecomment-2160457943
> looks fine i think.
>
> There would be a few signatures which could be left out, the new
`-IgnoreJDKClass` might help there in some cases since it filters out `java.*`
and `javax.*`.
>
> this should also make the following step from the script no longer
necessary (assuming it works as intended):
>
> ```
> # remove getPeer() calls
> find . -name "*.sig" -exec sed -i '/java.awt.peer.ComponentPeer/{N;d;}' {}
\;
> ```
>
> (and it would remove all the `@Deprecated`, `Set.*`, `Map.*` sigs too)
>
> `_serializedATN` should be also filtered out in my opinion since it dumps
a binary blob (from generated antlr code?) into the sig file. Binary blobs
should not be in repos since they are not reviewable (see xz).
>
> The question is should we do it now or the next time?
maybe next time ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
