mbien commented on PR #7659: URL: https://github.com/apache/netbeans/pull/7659#issuecomment-2284247217
> I can also just fix the GsfLanguage cases and wait for another report, if that's your preferred choice. @jtulach I am sure you know but this is a good time to point out that NetBeans does not have a QA team right now. Variants of this patch were reverted twice before if I remember correctly. I did also try to highlight (https://github.com/apache/netbeans/pull/7579#issuecomment-2228742269, https://github.com/apache/netbeans/pull/7579#issuecomment-2239738030, ..) the problem of 1) changes here have proven _repeatedly_ to affect seemingly unrelated areas of NB and 2) there seem to be no regression tests for any of this. All taken together: this is a very bad combination of things! So no, we can't go on like this and merge PRs to stabilize them in master (or delivery, which is worse). RC3 is soon to happen and this wouldn't be a good time to try to patch things up under those circumstances. If you author a PR as PMC/committer and your instincts tell you that this change is risky, you absolutely should make sure to test it well before trying to get it in. I am sorry to say this but I would advise a revert again https://github.com/apache/netbeans/pull/7650 since this is is the lowest risk action which brings us back to a state with empirical evidence that it worked fine before. I don't believe in vetos in a project with so many cooks, so I hope we can figure out the right thing to do without invoking them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
