lahodaj commented on PR #7659: URL: https://github.com/apache/netbeans/pull/7659#issuecomment-2285715189
We currently have a single-purpose hack to disable duplicate code completions: https://github.com/apache/netbeans/blob/14d5cbce8107d9fdaeea7e87af8f73796f10c936/ide/lsp.client/src/org/netbeans/modules/lsp/client/bindings/LspCompletionProviderImpl.java#L61 (which may seemingly be OK, but what happens when someone will register some special-purpose code completion for Enso - will that disable the lsp.client based code completion) And here proposal for another single-purpose hack (which, moreover, will be hard to understand to the users/clients, I think). Will we need more single-purpose hacks for other features? I am sorry, but I fail to see how this is better than having a single clear API (e.g. in a form of an annotation) saying "for mime-type <M>, please use `api.lsp` services to gather information to and let lsp.client use them to provide language support for <M>". (Maybe, if needed, we could enhance that to support exclusions - like use these `api.lsp` services and not these other ones, as I want to implement the other ones myself - but I don't think we are there, and may never get there.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
