sdedic commented on PR #7655: URL: https://github.com/apache/netbeans/pull/7655#issuecomment-2289469021
> Thanks! I'm concerned about introducing anything that might auto-execute the build tool without warning, particularly but not exclusively if the projects aren't trusted. Note: currently one could execute ACTION_PRIME with the same effect... and Maven does not implement trust concept, at the moment. This API contains a flag to mark the project trusted ( processed by the implementation), so if Maven impl some day implements trust checks, it will be able to fail the request with a documented status. BTW - with the API, trust concept can be added 'centrally' in front of passing the request to the impl (which can still do its own checks). > I can understand the need to reload with POM modification, but that shouldn't happen auto-magically. The fact is, that POM reload **already happens** mostly automagically, for all opened projects. Maven module itself schedules a reload on the background as well as Gradle. But an observer/client lacks a handle to wait for that schedule to complete. This API does does not do that on itself though - it needs "someone" who requests a refresh. With that comment, I particularly meant making sure we don't get into a situation like with the need to add a warning in the Micronaut wizard that was downloading and executing any old `mvnw` without knowledge! > Even then, Maven / Gradle (or even central impl, if we agree that it is useful) display at least cancellable progress indicator. The implementation is free to prompt the user (i.e. Maven impl might be changed to prompt before launching the priming build, since at that time, it already **knowns** some artifacts are missing). BTW - gradle does not do that atm. If one requests NbGradle.Quality.FULL_ONLINE on a trusted project, it will happily download all the world. > That depends on who the "we" is that needs this feature! 😉 Most of us are putting our spare time into this. Yeah, I realized that while you were replying and ashamed deleted the comment. sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
