sdedic commented on PR #7655: URL: https://github.com/apache/netbeans/pull/7655#issuecomment-2291824284
OK, I would like to focus the PR discussion back to what this PR's code does. The API itself does not say "how" (that's up to the implementation), just gives the client a way to *request* a certain project state - and blocks the operation (failed `Future`) if the implementation does not fullfill it. IMHO, overall it is better that clients DO NOT run "priming build" (which can fail, but the failure cannot be detected reliably btw) explicitly e.g. when classpath is incomplete, but instruct the project system to "make the project resolved" (somehow). The less the client knows what it means "resolve project" the better. The Reload API implementation in this PR now does just what would be done if the code was maven module's friend and used the existing friend APIs. We should still (elsewhere) argue if there should be a defined policy, or what that policy should be and why. But it's out of scope of this PR I think, since it does not introduce anything not done already - it actually hides the details behind an abstract API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
