matthiasblaesing commented on code in PR #7677:
URL: https://github.com/apache/netbeans/pull/7677#discussion_r1720953343


##########
ide/extexecution.process/manifest.mf:
##########
@@ -2,5 +2,5 @@ Manifest-Version: 1.0
 AutoUpdate-Show-In-Client: false
 OpenIDE-Module: org.netbeans.modules.extexecution.process
 OpenIDE-Module-Localizing-Bundle: 
org/netbeans/modules/extexecution/process/resources/Bundle.properties
-OpenIDE-Module-Specification-Version: 1.53
+OpenIDE-Module-Specification-Version: 2.0

Review Comment:
   I have mixed feelings here. On the one hand there is a massive change in the 
implementation (dependency bump, drop of native implementation), on the other 
hand the API did not change in any way. This is still marked a compatible 
change (same major release version), but to me the specification major bump 
implies different. I would just count it up to 1.54.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to