mbien commented on code in PR #7677:
URL: https://github.com/apache/netbeans/pull/7677#discussion_r1720957987


##########
ide/extexecution.process/manifest.mf:
##########
@@ -2,5 +2,5 @@ Manifest-Version: 1.0
 AutoUpdate-Show-In-Client: false
 OpenIDE-Module: org.netbeans.modules.extexecution.process
 OpenIDE-Module-Localizing-Bundle: 
org/netbeans/modules/extexecution/process/resources/Bundle.properties
-OpenIDE-Module-Specification-Version: 1.53
+OpenIDE-Module-Specification-Version: 2.0

Review Comment:
   this might sound weird, but i did actually use 1.54 first but then I thought 
@matthiasblaesing will probably suggest to go to 2.x just to be sure, since it 
bumps the lang level, the position in the lookup and changes the impl at the 
same time.
   
   I do think staying on 1.54 should be probably fine too. I have to squash 
anyway so i can change it if everyone is ok with 1.54.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to