matthiasblaesing commented on PR #7938:
URL: https://github.com/apache/netbeans/pull/7938#issuecomment-2537010129
Nice! Some quick notes:
- Initialy the SVG document was not opened with the now support. If I see
this correctly the module needs to be eager. With that change it works
correctly:
```diff
--- a/ide/svg/nbproject/project.properties
+++ b/ide/svg/nbproject/project.properties
@@ -1,2 +1,3 @@
+is.eager=true
javac.source=1.8
javac.compilerargs=-Xlint -Xlint:-serial
```
- Source files missing a license header:
- `BackgroundIcon.svg`
- `SVGPanel.java`
- `build.xml`
- The document icon `svgLogo.png` should have the svg sitting beside it, so
that it can be rendered with SVG icon support in NetBeans
- The license info for `svgLogo.png` should use comment
`COMMENT_UNSUPPORTED` (see
https://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/licenseinfo/CommentType.java#L22-L25)
- Given this module is new, I would go to source level 17 directly
- Commit should hold full name as author (you can see the author here:
https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/7938.patch or
`git log -n 5` or with the History View from NetBeans
- there are remaining changes to dependencies in
`idex/xml/nbproject/project.xml`
- changes to `platform/libs.batik.read` can be reverted in a new commit.
This should be squashed at the end anyway.
- Thumbnail support would be nice, but can be added later. The current state
is already a very nice improvement. Thank you!
- Also nice-to-have: image viewer has middle mouse button drag, but can also
added later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
