neilcsmith-net commented on code in PR #8114:
URL: https://github.com/apache/netbeans/pull/8114#discussion_r1904295966
##########
platform/openide.util.ui/src/org/openide/util/ImageUtilities.java:
##########
@@ -210,6 +210,59 @@ public static final Image loadImage(String resource,
boolean localized) {
return loadImageInternal(resource, localized);
}
+ /**
+ * Load an image from an URL. If the URL uses the {@code nbresloc}
protocol, it is loaded using
+ * the resource loading mechanism provided by {@link
#loadImage(java.lang.String)}. An SVG
+ * image may be substituted when available.
+ *
+ * <p>This method is intended for use only when a URL must be used instead
of a resource path,
+ * e.g. in the implementation of pre-existing NetBeans APIs.
+ *
+ * @param url the URL of the image, possibly with the nbresloc protocol
+ * @return the loaded image, or either null or an uninitialized image if
the image was not
+ * available
+ * @since 7.34
+ */
+ public static final Image loadImage(URL url) {
+ Parameters.notNull("icon", url);
+ if (url.getProtocol().equals("nbresloc")) { // NOI18N
+ // Omit the initial slash of the path.
+ return loadImage(url.getPath().substring(1));
+ } else {
+ /* Observed to return an image with size (-1, -1) if URL points to
a non-existent file
+ (after ensureLoaded(Image) is called). */
+ return Toolkit.getDefaultToolkit().createImage(url);
Review Comment:
@eirikbakke IMO, yes, and my comment was made knowing the exception would
need considering. It would remove the direct uses of `new URL(...` and
considering eg.
https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/net/URL.html#constructor-deprecation
we should slowly take a look at uses of URL. Besides the direct calls, some
of the URLs here are constructed from a String elsewhere and in ways that could
possibly be replaced by URI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
