JaroslavTulach commented on code in PR #8141: URL: https://github.com/apache/netbeans/pull/8141#discussion_r1912373824
########## ide/csl.api/src/org/netbeans/modules/csl/core/Language.java: ########## @@ -64,6 +73,97 @@ * @author <a href="mailto:[email protected]";>Tor Norbye</a> */ public final class Language { + // LanguageConfig#getOverridingMethods may return null, + // Language#getOverridingMethods may not, so return this dummy implementation + private static final OverridingMethods EMPTY_OVERRIDING_METHODS = new OverridingMethods() { Review Comment: I'd split these inner classes into separate package private implementation classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
