mbien commented on PR #8175: URL: https://github.com/apache/netbeans/pull/8175#issuecomment-2605077839
> In my own NetBeans Platform app I use a much brighter foreground color on dark mode: so do I (for the IDE i use `@foreground=#d1d1d1` and darken the accent color for selections - this fits well together with white selection foreground), but I didn't want to completely change the theme. Those are just adjustments. > Selection foreground should not be hardcoded - it's dynamic based on accent colour I am not sure about this. It _is_ the setting for the dark theme, white works for accent colors. I don't know how to darken accent colors for dark themes without causing an endless loop in the parser (maybe we should just add darker variants?). If it works better than the computed color -> its good enough for me. > I wouldn't change just the popup switcher either, as these default to combobox colours. comboboxes look fine to me and are far less complex than the tab switcher which has 2 different kinds of decorators iteracting with each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
