neilcsmith-net commented on PR #8175: URL: https://github.com/apache/netbeans/pull/8175#issuecomment-2605135235
Given the user can select any colour they want as the accent colour, that won't work. Dark text for selected items is the right approach there. Changing the selection foreground to a fixed colour is a no go. If you want to fix just the tab popup for now, do that, although is there a reason to mix `$MenuItem` and `$List` values - just `$MenuItem` makes sense? The contrast accessibility issues are covered in the linked upstream issue. Changing foreground to `#cccccc` is _just_ about a pass and improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
