mbien commented on code in PR #8194:
URL: https://github.com/apache/netbeans/pull/8194#discussion_r1929627802
##########
ide/html.editor/src/org/netbeans/modules/html/editor/completion/HtmlPaletteCompletionProvider.java:
##########
@@ -298,7 +299,7 @@ public String getRightHtmlText() {
}
public ImageIcon getIcon() {
- return new ImageIcon(icon);
+ return
ImageUtilities.icon2ImageIcon(ImageUtilities.image2Icon(icon));
}
Review Comment:
nitpick: move conversion to constructor?
##########
enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/TransactionView.java:
##########
@@ -310,8 +310,8 @@ public void actionPerformed(ActionEvent e) {
}
}});
- timeDButton = new JToggleButton(new ImageIcon(
-
TransactionView.class.getResource("/org/netbeans/modules/web/monitor/client/icons/timesortB.gif")),
true);
+ timeDButton = new JToggleButton(ImageUtilities.loadIcon(
+
"org/netbeans/modules/web/monitor/client/icons/timesortB.gif"), true);
Review Comment:
nitpick: the `true` might be a mistake? It is the only icon in this class
where localization is requested. Although I don't even know how to get to that
window so it might not be worth the risk to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
