eirikbakke commented on code in PR #8194:
URL: https://github.com/apache/netbeans/pull/8194#discussion_r1929826486
##########
enterprise/web.monitor/src/org/netbeans/modules/web/monitor/client/TransactionView.java:
##########
@@ -310,8 +310,8 @@ public void actionPerformed(ActionEvent e) {
}
}});
- timeDButton = new JToggleButton(new ImageIcon(
-
TransactionView.class.getResource("/org/netbeans/modules/web/monitor/client/icons/timesortB.gif")),
true);
+ timeDButton = new JToggleButton(ImageUtilities.loadIcon(
+
"org/netbeans/modules/web/monitor/client/icons/timesortB.gif"), true);
Review Comment:
@neilcsmith-net Icons should normally be language-independent, ideally
without text. The exception could be things like sortAZ, which might show the
letters "A" and "Z" in English but the letters "A" and "Å" in Norwegian (if
internationalized sort is actually supported). Or an icon in a spreadsheet app
which displays "0.00" in the US might show "0,00" in the Norwegian version. But
those cases are exceptions, not the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
