mbien commented on code in PR #8217:
URL: https://github.com/apache/netbeans/pull/8217#discussion_r1938220760
##########
java/java.graph/src/org/netbeans/modules/java/graph/FruchtermanReingoldLayout.java:
##########
@@ -382,7 +382,8 @@ private void relayoutNonFixed(NodeWidget w) {
r = 30;
theta = 0;
w.setFixed(false);
- while (true) {
+ // 48 - ~3 times round?
+ for (int i = 0; i < 48; i++) {
Review Comment:
If I read this right it will stop moving the node if it can't find a free
spot after a few attempts. Makes sense.
##########
java/java.graph/src/org/netbeans/modules/java/graph/FruchtermanReingoldLayout.java:
##########
@@ -150,7 +150,7 @@ private void init() {
bounds = new Rectangle(magicSizeConstant + (magicSizeMultiplier *
nds),
magicSizeConstant + (magicSizeMultiplier *
nds)); //g.getMaximumBounds();
temp = bounds.getWidth() / 10;
- forceConstant = 0.75 * Math.sqrt(bounds.getHeight() *
bounds.getWidth() / nds);
+ forceConstant = 1.75 * Math.sqrt(bounds.getHeight() *
bounds.getWidth() / nds);
Review Comment:
not sure about changing the weights, but the graph looks somewhat similar
still so its probably fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
