neilcsmith-net commented on code in PR #8217:
URL: https://github.com/apache/netbeans/pull/8217#discussion_r1938255114
##########
java/java.graph/src/org/netbeans/modules/java/graph/FruchtermanReingoldLayout.java:
##########
@@ -382,7 +382,8 @@ private void relayoutNonFixed(NodeWidget w) {
r = 30;
theta = 0;
w.setFixed(false);
- while (true) {
+ // 48 - ~3 times round?
+ for (int i = 0; i < 48; i++) {
Review Comment:
Yes. What I'm less sure about is why it doesn't come to an end given the
increase in `r`. Increasing the increment of `r` does get the loop to end on my
test project (with a result similar to that of increasing the forces), but
takes longer, and is potentially still liable to get stuck with a different set
of nodes.
This whole thing could do with a proper look after NB25. I find the
horizontal tree (in popup menu -> layout) a potentially more useful display for
smaller projects, and might be a better default given it uses a lot less CPU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
