mbien commented on code in PR #8235:
URL: https://github.com/apache/netbeans/pull/8235#discussion_r1951876863
##########
platform/openide.util.ui/src/org/openide/util/ImageUtilities.java:
##########
@@ -1086,29 +1049,7 @@ private static ColorModel colorModel(int transparency) {
/**
* Key used for composite images -- it holds image identities
*/
- private static class CompositeImageKey {
- Image baseImage;
- Image overlayImage;
- int x;
- int y;
-
- CompositeImageKey(Image base, Image overlay, int x, int y) {
- this.x = x;
- this.y = y;
- this.baseImage = base;
- this.overlayImage = overlay;
- }
-
- @Override
- public boolean equals(Object other) {
- if (!(other instanceof CompositeImageKey)) {
- return false;
- }
-
- CompositeImageKey k = (CompositeImageKey) other;
-
- return (x == k.x) && (y == k.y) && (baseImage == k.baseImage) &&
(overlayImage == k.overlayImage);
- }
+ private record CompositeImageKey(Image baseImage, Image overlayImage, int
x, int y) {
Review Comment:
good catch - will add the custom equals again. I kept it originally but when
I looked through it today I must have overlooked that the images were compared
with `==`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
