eirikbakke commented on PR #8235: URL: https://github.com/apache/netbeans/pull/8235#issuecomment-2654733715
Nice catch regarding nbresloc vs. nbres! We should handle both. There is an explanation of the difference here: https://netbeans.apache.org/wiki/main/netbeansdevelopperfaq/DevFaqUriVsUrl/ Apparently, nbresloc should use localization while nbres should not. So they should be handled the same except with a different second argument to loadImage(String,boolean). Perhaps you could just add this as part of this URL? Maybe also update the Javadoc of loadImage(URI) to refer to say "nbres or nbresloc protocols" instead of just "nbresloc". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
