eirikbakke commented on code in PR #8310:
URL: https://github.com/apache/netbeans/pull/8310#discussion_r1990439564


##########
platform/core.windows/src/org/netbeans/core/windows/view/dnd/DragWindow.java:
##########
@@ -44,6 +46,9 @@
  * @author sa
  */
 class DragWindow extends JWindow {
+    /* Store buffers at 2x the logical resolution. Then scale them down by 50% 
when painting to the
+    JWindow. This ensures full-resolution painting on HiDPI and Retina 
screens. */
+    private static final int DPI_SCALE = 2;
 
     private boolean useFadeEffects = !Boolean.getBoolean( 
"winsys.dnd.nofadeeffects" );

Review Comment:
   Hmm, I'm not seeing much of what the fade effect is doing, on either Windows 
or MacOS, despite it being confirmed to be on. In general I tend to prefer to 
remove all animations that don't have a very specific purpose. The drag image 
itself is enough to show what is going on. Should I just remove the animation 
code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to