eirikbakke commented on code in PR #8310:
URL: https://github.com/apache/netbeans/pull/8310#discussion_r1990486502


##########
platform/core.windows/src/org/netbeans/core/windows/view/dnd/DragWindow.java:
##########
@@ -44,6 +46,9 @@
  * @author sa
  */
 class DragWindow extends JWindow {
+    /* Store buffers at 2x the logical resolution. Then scale them down by 50% 
when painting to the
+    JWindow. This ensures full-resolution painting on HiDPI and Retina 
screens. */
+    private static final int DPI_SCALE = 2;
 
     private boolean useFadeEffects = !Boolean.getBoolean( 
"winsys.dnd.nofadeeffects" );

Review Comment:
   Ah, now I see what the fade is doing, and I see the flickering you mention 
too on dark mode. But it's easy to remedy the flicker... it's just a matter of 
setting the window background color appropriately for the light vs. dark LAF.
   
   I will try to make a version that rips out the complicated animation code 
while avoiding the flickering.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to