tehnic-take3 commented on PR #8370: URL: https://github.com/apache/netbeans/pull/8370#issuecomment-2771955532
Well, Eclipselink 4.0.5 accepts this "malformed" PU. I tested with an invalid transaction-type too: OpenJPA throws a SAXParseException very early on loading and Eclipselink throws an IllegalArgumentException later on usage. I guess Eclipselink does not verify persistence.xml at all. I considered to remove persistence-3.1.xml completely too, but maybe another implementation (Eclipselink?) uses persistence:Version internally and removing it would break existing usage. Also Persistence.VERSION_3.1 is used in a lot of other places within j2ee.persistence and enterprise. I found there more places where i should add OpenJPA 3.0 too. For this reason i would let the current persistence-3.1.xml, inclusive usage, as is and add only OpenJPA 3.0. I not checked/tested any other implementation (hibernate, ...). I'll try to implement your suggested changes and a more complete patch until 15.04. (feature freeze) in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
