tehnic-take3 commented on PR #8370: URL: https://github.com/apache/netbeans/pull/8370#issuecomment-2765351635
I agree with your comments, essentially i only added 3.0 and 3.1 to existing OpenJPA implementation without any refactoring. Before i touch the superclass i need to review the unit tests to avoid any breaking changes. Anyway i found another point i need to understand/solve: In ui/resources/persistence/persinstence-3.1.xml: xsi:schemaLocation="https://jakarta.ee/xml/ns/persistence https://jakarta.ee/xml/ns/persistence/persistence_3_0.xsd"; version="3.1"> This creates an invalid persistence unit (validation exception), at least for OpenJPA, because version="3.1" is not allowed in persistence_3_0.xsd: <xsd:attribute name="version" type="persistence:versionType" fixed="3.0" use="required"/> According to my interpretation of JPA 3.1, version="3.0" must be used for persistence.xml, but version="3.1" must be used in orm.xml (due to the new generator UUID). In order to not break existing usage, i'm considering simply not implementing OpenJPA 3.1 (OpenJPA 3.0 is enough). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
